DataGrid 2 swipe actions

[Mike Kerner]

are you sure that's a good idea?  michael's PR breaks mobile scrolling.
 i'm all ears on how mobile scrolling can work without delayTouches set to
true.

On Thu, Aug 27, 2020 at 4:24 PM Mark Waddingham via use-livecode <
use-livecode at lists.runrev.com> wrote:

> Heh - well I said ‘well structured’ not ‘literary’...
>
> Although that being said, the ‘singular’ noun ‘drag’ has a plural and I
> believe it is ‘drags’...
>
> e.g. ‘It took several drags of her long fingernails down the blackboard to
> make the class pay attention’ ;)
>
> If your fix works for you - great...
>
> Unfortunately it breaks some functionality for others so isn’t mergeable
> as it stands.
>
> Warmest Regards,
>
> Mark.
>
> Sent from my iPhone
>
> > On 27 Aug 2020, at 20:58, Mike Kerner via use-livecode <
> use-livecode at lists.runrev.com> wrote:
> >
> > Don't be telling me about "well structured commit titles".  There is
> > nothing clear in that title, unless British is your first language, and
> > English is your second, and in British we add an "s" on the ends of every
> > singulars nouns, and peoples speak with a lisps.
> > In the meantime(s), setting the delayTouches to false(s) on a DG(s)
> breaks
> > scrolling(s), thus my PR(s), from however-long-ago it(s) was. :-P
> > Tag.  You(s)'re it(s)
> >
> >> On Thu, Aug 27, 2020 at 2:17 PM Mark Waddingham via use-livecode <
> >> use-livecode at lists.runrev.com> wrote:
> >>
> >>> On 2020-08-27 17:07, Mike Kerner via use-livecode wrote:
> >>> name's mikey.  y'all can call me...
> >>> mikey
> >>>
> >>> howdy.
> >>>
> >>> i think it was just one line of code, too, right?  it was just a matter
> >>> of
> >>> setting the delayTouches to true.  i have no idea why it was originally
> >>> "false".
> >>
> >> Well, the advantage of generally trying to make sure all substantive
> >> changes made to the source have well structured commit titles and decent
> >> descriptions in the body means its easy to find out by grokking `git
> >> log` :D
> >>
> >> It was changed precisely because of the issues Andrew pointed out with
> >> DG2, specifically in this commit:
> >>
> >> commit ac1beee1dd113e203b6715fe472cf2fa88656bd5
> >> Author: Michael McCreary <michael.mccreary at runrev.com>
> >> Date:   Thu Dec 21 12:49:26 2017 +0000
> >>
> >>     [[ DataGrid 2 ]] Fix drags to cooperate with the mobile scroller.
> >>
> >>     Previously, a data grid's mobile scroller was getting in the way of
> >>     reorder and swipe actions.
> >>
> >>     To fix for reordering, we disable the scroller whenn the user clicks
> >>     on a reorder control (and re-enable it when the reorder completes).
> >>
> >>     Swipes are a little trickier. We track dragging on mouse down, but
> >>     disabling the scroller at this point will prevent all scrolling.
> >>     Instead we attempt to determine if the user is trying to drag the
> >>     row before disabling the scroller.
> >>
> >> I'd need to do some more digging to see if the highlight on touch has
> >> actually been caused by something else since  as I don't recall it being
> >> an issue, or noticed when DG2 debuted - but I could be wrong. Especially
> >> more since Android has never had a delayTouches mode.
> >>
> >> Either this problem also affects Android, which means turning
> >> delayTouches on is not really an option (given the negative consequences
> >> to DG2 behavior); or it doesn't affect Android in which case something
> >> else has changed (potentially in the iOS scroller control itself).
> >>
> >> I suspect we will just need a short timer on mouse down so that it only
> >> triggers a highlight *if* a scroll message isn't received within the
> >> interval of the timer.
> >>
> >> Warmest Regards,
> >>
> >> Mark.
> >>
> >> --
> >> Mark Waddingham ~ mark at livecode.com ~ http://www.livecode.com/
> >> LiveCode: Everyone can create apps
> >>
> >> _______________________________________________
> >> use-livecode mailing list
> >> use-livecode at lists.runrev.com
> >> Please visit this url to subscribe, unsubscribe and manage your
> >> subscription preferences:
> >> http://lists.runrev.com/mailman/listinfo/use-livecode
> >>
> >
> >
> > --
> > On the first day, God created the heavens and the Earth
> > On the second day, God created the oceans.
> > On the third day, God put the animals on hold for a few hours,
> >   and did a little diving.
> > And God said, "This is good."
> > _______________________________________________
> > use-livecode mailing list
> > use-livecode at lists.runrev.com
> > Please visit this url to subscribe, unsubscribe and manage your
> subscription preferences:
> > http://lists.runrev.com/mailman/listinfo/use-livecode
>
>
> _______________________________________________
> use-livecode mailing list
> use-livecode at lists.runrev.com
> Please visit this url to subscribe, unsubscribe and manage your
> subscription preferences:
> http://lists.runrev.com/mailman/listinfo/use-livecode
>


-- 
On the first day, God created the heavens and the Earth
On the second day, God created the oceans.
On the third day, God put the animals on hold for a few hours,
   and did a little diving.
And God said, "This is good."