This Is Why We Can't Have Nice Things

Mark Wieder mwieder at ahsoftware.net
Thu Sep 10 21:03:44 EDT 2015


On 09/10/2015 12:39 AM, Mark Waddingham wrote:

> I do wonder if a GitHub hook could be used here. Peter's done some great
> things with them in terms of PR review, CLA checking and CI via our
> 'vulcanbot' build system.
>
> If PRs which contain stacks were monitored by vulcan, it might be able
> to pick up when they aren't going to merge due to binary reasons and
> provide a link to a page which shows the diff so at least the review
> process could start and provide feedback to the submitter. It would
> still be a chunk of work to integrate such things (as if the target
> stack had changed since the submitted stack was modified, you can't just
> copy the submitted one over the target one) but at the very least that
> would give a list of changes that need to be applied.

That's an interesting idea.
I wonder if it might make sense in that case to ask that pull requests 
not have more than x binary (non-script) changes or this might easily 
get to be an overwhelming task.

-- 
  Mark Wieder
  ahsoftware at gmail.com




More information about the use-livecode mailing list